[llvm-dev] Codifying our Brace rules-

[Diana Picus via llvm-dev]

Hi,

FWIW, I'm on the always-add-braces camp, for the already mentioned
reasons and also the following:
* It makes it easier to add and remove one-off debug code that you
don't intend to commit
* It makes it easier for my editor to jump over the whole block while
scrolling back and forth around code

I also like chill's suggestion, since it at least solves the second issue.

Cheers,
Diana

On Tue, 16 Jun 2020 at 10:35, Momchil Velikov via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> My 2 pennies is braces add unnecessary clutter and impair readability when
> used on a *single-line* statement. I count comments, that are on their
> own line as statement(s).
>
> For example:
>
> BAD:
>
> if (cond)
>   // Comment
>   foo();
>
>
> GOOD:
> if (cond) {
>   // Comment
>   foo();
> }
>
> BAD:
> if (cond) {
>   foo(); // Comment
> }
>
> GOOD:
> if (cond)
>   foo(); // Comment
>
> BAD:
> if (cond)
>   for(;;)
>     foo()
>
>
> GOOD:
> if (cond) {
>   for(;;)
>     foo()
> }
>
> Some new-ish languages like Go and Swift went to always require braces. However, I've never
> seen a study, which concluded that always requiring braces has an overall positive effect
> on code quality.
>
> Is there such a thing?
>
> Lacking that, it becomes a matter of personal taste and preference and anecdotal evidence
> in favour of one or the other style. Speaking of which, as I constantly run clang-format
> on the blocks of code, that I currently modify, I don't think I've ever misplaced a statement.
>
> ~chill
>
> --
> Compiler scrub, Arm
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev