[llvm-dev] Codifying our Brace rules-

[Keane, Erich via llvm-dev]

Hi all-

A few weeks ago I noticed that our "omit braces with single line blocks" rule wasn't written down!  Additionally, as a group on IRC and in review, noticed that the enforcement of this rule has been extremely inconsistent.  We made a first run at codifying our existing practice here: https://reviews.llvm.org/D80947, which was then committed after significant time on llvm-commits.

I would like to encourage the list via discussion and further reviews/commits to come to a consensus on what we actually MEAN by this rule.  For example, a recent comment points out that :

If (cond)
  Stmt;
else if (cond)
  Stmt;
else {
  Stmt;
  Stmt;
}

Should require braces on all of the conditions!  However, we are extraordinarily inconsistent here.  My wish is for us to become more consistent, so I would like us to use this thread to organize our collective thoughts on figuring out what the rule actually SHOULD be, and organizing a handful of commits to the coding standard to make sure it says what we mean.

Thanks,
Erich
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200615/8508aa9c/attachment.html>