[llvm-dev] Phabricator sending spurious "This revision was not accepted when it landed" emails

[Robinson, Paul via llvm-dev]

I believe that can happen when someone says LGTM in a reply, but doesn’t do the drop-down to Accept Revision.
The flip side is if you do the drop-down and don’t put in a reply, there’s no notice to the mailing list.
--paulr

From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of James Henderson via llvm-dev
Sent: Tuesday, July 21, 2020 7:46 AM
To: Jay Foad <jay.foad at gmail.com>
Cc: LLVM Developers Mailing List <llvm-dev at lists.llvm.org>
Subject: Re: [llvm-dev] Phabricator sending spurious "This revision was not accepted when it landed" emails

Yes, I've seen them occasionally, although not always as far as I've noticed.

James

On Tue, 21 Jul 2020 at 12:25, Jay Foad via llvm-dev <llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>> wrote:
Has anyone else noticed Phabricator sending emails saying:
  This revision was not accepted when it landed; it landed in state
"Needs Review".
when the review clearly has been accepted by someone?

Some recent examples:
https://reviews.llvm.org/D83952
https://reviews.llvm.org/D80116
https://reviews.llvm.org/D81267

Thanks,
Jay.
_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200721/d93d26fe/attachment.html>