[llvm-dev] Heads-up: Handling target-specific intrinsics in InstCombine

[Philip Reames via llvm-dev]

Definite +1 on the general direction.

Philip

On 6/29/20 5:29 AM, Nicolai Hähnle via llvm-dev wrote:
> Hello,
>
> this mail is to raise awareness of https://reviews.llvm.org/D81728,
> which is substantial enough of a conceptual change that it should
> probably at least be mentioned in llvm-dev.
>
> InstCombine has dealt with target-specific intrinsics for a long time,
> since its fix-point iteration is arguably the right place to do so. A
> downside is that there's a pull to add an increasing amount of code
> into lib/Transforms/InstCombine/ that really is target-specific.
>
> What the aforementioned change does is provide a target hook via
> TargetTransformInfo, and move the handling of all target intrinsics
> for InstCombine purposes into the corresponding lib/Target/$foo/
> directory via the hook, thus cleaning up the core of InstCombine.
>
> Cheers,
> Nicolai