[llvm-dev] DWARF debug line error handling changes
David Blaikie via llvm-dev
llvm-dev at lists.llvm.org
Fri Jan 31 07:13:45 PST 2020
I don't think it's vitally pressing or anything - just trying to delegate
some of the deluge of code review/coaxing all these DWARF changes (at least
the line table improvements and the DWARF64 improvements - and I think
there's one other group/project happening too? (DWARF5 features like the
defaulted template parameters, implicit_pointer, etc))
On Fri, Jan 31, 2020 at 6:17 AM Pavel Labath <pavel at labath.sk> wrote:
> On 31/01/2020 01:31, David Blaikie wrote:
> > On Wed, Jan 29, 2020 at 2:28 AM Pavel Labath <pavel at labath.sk
> > <mailto:pavel at labath.sk>> wrote:
> > On 28/01/2020 20:37, David Blaikie via llvm-dev wrote:
> > > and one idea I had was to have the DWARFDataExtractor return a new
> > > DWARFDataExtractor that was specifically bounded to the parsed
> > > for this reason.
> > I think this would be great. In fact, I was getting ready to propose
> > something like that myself. :)
> > FWIW, lldb DataExtractors already support this kind of slicing.
> > Oh, great - I'm sort of inundated with code reviews and things these
> > days - so could I prevail upon you to implement that & pick up some of
> > these line table reviews to either coax the use of such an entity there,
> > or port a few places (at least all the DWARF32/64 length parsing
> > duplicates - there's 3-4 copies of the code that does the 32/64 length
> > dance and validates the length of a header or similar in there)?
> > Tagged you in a few reviews (some committed already/approved - but
> > places that could benefit from cleanup with such a
> > device) https://reviews.llvm.org/D72155 https://reviews.llvm.org/D73618
> Well, I am afraid in this case, "getting ready" is a pretty long-term
> process :/, and I don't think I'll be able to get to this next week,
> because I'll be travelling.
> But I think I should be able to squeeze that in the week after that.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev