[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?

David Greene via llvm-dev llvm-dev at lists.llvm.org
Wed Jan 29 13:11:09 PST 2020

Nicolai Hähnle <nhaehnle at gmail.com> writes:

> On Wed, Jan 22, 2020 at 10:57 PM David Greene via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
>> David Blaikie <dblaikie at gmail.com> writes:
>> >> I can certainly see the utility of this.  I've never tried it since
>> >> posting patches via the web interface is not at all convenient
>> >
>> > Perhaps this is covered elsewhere but I'm still not super clear on "not at
>> > all convenient" - there's a form you fill in and attach the patch file.
>> With GitHub PRs:
>>   git push origin HEAD
>>   load up GitHub in a browser
>>   open a PR, select reviewers
>>   click "Create"
>> With Phab:
>>   load up Phab in a browser
>>   for N = ${number of patches - 1} to 0; do
>>      git diff -U9999999999 HEAD~${N} > patch.txt
>>      click "Differential"
>>      click "+ Create Diff", set reviewers, etc.
>>      click "Next"
>>      copy-and-paste text from patch.txt
>>      click "Submit"
>>      link to previous patch
>>   done
> It doesn't have to be so complicated. You can do:
> git rebase -i $base -x "arc diff @^"
> ... which works both for the initial posting and for updating reviews.
> Maybe you don't like / can't use(???) Arcanist, but it seems there are
> alternatives that are being discussed in other threads.

The whole point of describing this is that I can't use Arcanist.  If
another tools works, great.  We would need some sort of official-ish
support of any such tool though.


More information about the llvm-dev mailing list