[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?

David Greene via llvm-dev llvm-dev at lists.llvm.org
Tue Jan 28 08:09:14 PST 2020

"Doerfert, Johannes" <jdoerfert at anl.gov> writes:

> As I understand it, the GH model is to amend a new commit to your PR
> which addresses the review comments.

I'm fine with that during the review process as long as the commit
history is cleaned up before final merge.

> The "problem" is that "we" are used to the force push model in which
> each commit is always as "clean and self contained" as possible (this
> is not only because of Phab I'd argue).

The question is if everything is approved and the author does a final
cleanup as alluded to above, does that final cleanup also need to go
through review?


More information about the llvm-dev mailing list