[llvm-dev] Phabricator -> GitHub PRs?

Kristina Brooks via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 23 16:29:54 PST 2020


Not intended to be a strong opinion but I prefer Phab as a dedicated
code review tool. In addition to that, it has accumulated quite a
number of differentials making it easy to reference past reviews, as
well as SVN commits that happened before the decision to migrate to
Git was made. While I haven't had excellent experiences with Arcanist
and only used it a few times, I think referencing differentials (in
form of `Differential Revision: ...`) in commit messages is easy
enough without needing a separate tool for it. While I understand the
desire to use Git (and hence the GitHub migration) as a VCS, that
doesn't necessarily translate to positive experiences with GitHub
itself, especially as a code review tool. Phab, in my opinion, can be
used just fine without Arcanist (which uses Phab's Conduit API). I
don't think frustrating experiences with Arcanist necessarily
translate to negative experiences with Phab. I know that some hold a
different opinion, but I think GitHub tries to do too much, but not
necessarily as well as dedicated tools.

On Wed, Jan 8, 2020 at 12:03 AM Bill Wendling via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> Now that we're on GitHub, can we *please* move to GitHub PRs? As much as I hate git, I hate Phabricator/Archanist even more. They're super clunky and makes working in git that much worse.
>
> -bw
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev


More information about the llvm-dev mailing list