[llvm-dev] [llvm-exegesis]?==?utf-8?q? [RFC] Renaming Uops- classes

Milos Stojanovic via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 16 11:04:05 PST 2020


Since the option of running -mode=inverse_throughput was added to llvm-exegesis the names of classes like UopsSnippetGenerator and UopsBenchmarkRunner, that this mode shares with uops, started to be less descriptive.

Inverse_throughput doesn't use the uops counters, so for example, the instruction layout shared between these two modes is really connected to parallelism, not uops. It's doubly confusing for architectures that don't even have any uops counters to constantly use classes with Uops in their name.
Because of this it would probably be easier to follow the code if the shared classes/methods would be renamed to something like Parallel- instead of Uops-. To keep it consistent Latency- could also be renamed to Serial-.

I can submit a patch if you think making this change would be reasonable.

Regards,
MiloŇ°
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200116/badd6db7/attachment.html>


More information about the llvm-dev mailing list