[llvm-dev] Phabricator -> GitHub PRs?
Renato Golin via llvm-dev
llvm-dev at lists.llvm.org
Thu Jan 16 11:00:17 PST 2020
On Thu, 16 Jan 2020 at 18:45, David Blaikie <dblaikie at gmail.com> wrote:
> I'm not sure where the idea that a patch series is anything other than that ^ came from. When I was talking about a patch series, it was/is with that definition in mind - ordered/dependent commits. I said "dependent series" to reinforce this idea that the kind of situation I was describing was one in which later patches in the series depend on the changes in earlier patches.
Perhaps it's my confusion in interpreting the answers.
Some comments mentioned "if a review spawns a related change", which
to me is a different review, and I've reviewed many of those cases.
Most people use the Phab link to express relationship, but that's not
Others said "some patches may be approved before others" which only
works in a series if they're from start to N, not N to M, nor M to the
end, nor randomly approved. In this case, the series is split in two,
with the latter having to be rebased on patches committed after the
first part is, so essentially, creating a new series.
Doing both these cases as a pull request is trivial.
Related changes become separate PRs with mention. GitHub creates the
links, like Phab if you tag on the commit message or comments.
Series split is harder, but still trivial. You create a new branch,
move up to the approved patch, push. Rebase your old branch and you
have a new series.
In Github you can choose to close the PR and open a new one, or just
push again and the UI should update the range. I prefer the former,
because you keep the comments history.
I would have done the same process in Phab, but with more clicks,
uploads, links, etc.
More information about the llvm-dev