[llvm-dev] Git autocrlf for Windows - why does the Getting Started guide say to use false?

Reid Kleckner via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 16 10:38:37 PST 2020


On Thu, Jan 16, 2020 at 9:36 AM Robinson, Paul via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> I’m inclined to think the llvm.org docs should say to use “input” on
> Windows, we’ve been happy with that in the Sony repo as James mentioned.
>
> But I’d also like to hear from a Windows user from outside Sony first.
>

I also think we should recommend `input`, if it does what I think it does:
convert from CRLF to LF, and never back.

This can break a few cases:
- adding binary files for a test that you forgot to mark binary
- adding CRLF text files for a test that you forgot to mark binary

These seem like more common exceptions than adding a new source file, which
are often mistakenly committed with CRLF. Any screwups, reverts, and bot
breakages from that seem less costly than accidentally adding line ending
changes, which live forever as a tax on `git annotate`.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200116/d0087352/attachment.html>


More information about the llvm-dev mailing list