[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?

David Blaikie via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 16 10:32:50 PST 2020

On Thu, Jan 16, 2020 at 10:10 AM David Greene via cfe-dev <
cfe-dev at lists.llvm.org> wrote:

> "Doerfert, Johannes via llvm-dev" <llvm-dev at lists.llvm.org> writes:
> > The first was this one https://reviews.llvm.org/D69785, since then the
> > series grew in all directions (see the stack).
> How do I see the stack?
> This is a great example of the (to me) unintuitive interface of Phab.
> People talk about things like "the stack" as if it's obvious and it's
> really not.

Yeah, once something's got a lot of commenting on it - but there's two
instances of the word "stack" when I open and search that page. The first
one is the one you're looking for I think - under "Revision Contents"
there's "Files", "History", "Commits", "Stack", and "Similar".

If you open "Stack" it shows various related and not so related commits in
the timeline - if you look at the line related to this review (highlighted
in yellow) you can see that this patch is on the purple coloured stack. So
you can see patches built up on top of it, such as D69922.

If you're reviewing this patch - in the timeline of comments you'd see a
structured event description like "jdoerfert
<https://reviews.llvm.org/p/jdoerfert/> added a child revision: D69922:
[OpenMP] Use the OpenMP-IR-Builder <https://reviews.llvm.org/D69922>."
telling you that there was a new patch added that is based on top of this

>                         -David
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200116/127ad087/attachment.html>

More information about the llvm-dev mailing list