[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?
David Greene via llvm-dev
llvm-dev at lists.llvm.org
Thu Jan 16 10:17:28 PST 2020
Hubert Tong <hubert.reinterpretcast at gmail.com> writes:
>> I can see how having multiple patches up at once for review might speed
>> things up. But what if a very first patch in a series needs major
>> changes and that affects every single following patch? The series has
>> to be re-posted anyway, right?
> Even if it is being re-posted anyway, it does not mean the reviews for the
> latter patches "restart at zero". An "major" interface change flowing from
> the first patch might lead only to mechanical changes that would be
> considered NFC to "status quo" of the later patches in the series. A force
> push with GitHub would harm such a workflow, but Phabricator handles such
> use cases well.
I have never really played with a multiple-commits-per-PR model in
GitHub so I don't know what happens with a rebase. Do all the previous
review comments disappear or something else? I would like to understand
the differences between GitHub and Phab when a rebase happens.
More information about the llvm-dev