[llvm-dev] merge_guards_bot reports clang-tidy/clang-format findings unrelated to modified code

Christian K├╝hnel via llvm-dev llvm-dev at lists.llvm.org
Mon Jan 13 07:52:43 PST 2020


+Mikhail Goncharov <goncharov at google.com>

Hi Fangrui,

I'm glad you like the tool!

We got a bunch of issues reported around clang-tidy, so Mikhail disabled it
today. Since the thread has a few other points, I created a separate
issue [1] for it.

The linter script [2] is already using clang-tidy-diff on the git diff. So
it should only look into changed lines...

[1] https://github.com/google/llvm-premerge-checks/issues/94
[2]
https://github.com/google/llvm-premerge-checks/blob/master/scripts/lint.sh

Best,
Christian

On Sat, Jan 4, 2020 at 7:59 PM Mark de Wever via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> On Fri, Jan 03, 2020 at 04:36:25PM +0000, Doerfert, Johannes via llvm-dev
> wrote:
> > I second Fangrui's findings and add:
> >
> > - clang-format should only run on "source" files. For one, it runs on
> >   non-C/C++ files right now with the results you can imagine. Even if it
> >   is a C/C++ test we do not always want to format it.
>
> I already file a bug report to request not to format the tests [1].
>
> [1] https://github.com/google/llvm-premerge-checks/issues/89
>
>
> Kind regards,
> Mark de Wever
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>


-- 
Best,
Christian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200113/1013b894/attachment.html>


More information about the llvm-dev mailing list