[llvm-dev] merge_guards_bot reports clang-tidy/clang-format findings unrelated to modified code
Christian Kühnel via llvm-dev
llvm-dev at lists.llvm.org
Mon Jan 13 07:52:43 PST 2020
+Mikhail Goncharov <goncharov at google.com>
I'm glad you like the tool!
We got a bunch of issues reported around clang-tidy, so Mikhail disabled it
today. Since the thread has a few other points, I created a separate
issue  for it.
The linter script  is already using clang-tidy-diff on the git diff. So
it should only look into changed lines...
On Sat, Jan 4, 2020 at 7:59 PM Mark de Wever via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Fri, Jan 03, 2020 at 04:36:25PM +0000, Doerfert, Johannes via llvm-dev
> > I second Fangrui's findings and add:
> > - clang-format should only run on "source" files. For one, it runs on
> > non-C/C++ files right now with the results you can imagine. Even if it
> > is a C/C++ test we do not always want to format it.
> I already file a bug report to request not to format the tests .
>  https://github.com/google/llvm-premerge-checks/issues/89
> Kind regards,
> Mark de Wever
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev