[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?

[Shoaib Meenai via llvm-dev]

This is very belated (and I don’t want the revive the entire discussion), but https://reviews.llvm.org/D74990 will make arc only upload your current patch by default (instead of the entire series).

From: cfe-dev <cfe-dev-bounces at lists.llvm.org> on behalf of cfe-dev <cfe-dev at lists.llvm.org>
Reply-To: Bill Wendling <isanbard at gmail.com>
Date: Tuesday, January 7, 2020 at 5:57 PM
To: Jonas Devlieghere <jonas at devlieghere.com>
Cc: llvm-dev <llvm-dev at lists.llvm.org>, cfe-dev <cfe-dev at lists.llvm.org>
Subject: Re: [cfe-dev] [llvm-dev] Phabricator -> GitHub PRs?

On Tue, Jan 7, 2020 at 5:35 PM Jonas Devlieghere <jonas at devlieghere.com<mailto:jonas at devlieghere.com>> wrote:
On Tue, Jan 7, 2020 at 5:16 PM Bill Wendling via cfe-dev
<cfe-dev at lists.llvm.org<mailto:cfe-dev at lists.llvm.org>> wrote:
>
> On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov<mailto:jdoerfert at anl.gov>> wrote:
>>
>> Hi Bill,
>>
>> On 01/07, Bill Wendling via llvm-dev wrote:
>> > Then perhaps those opposed could suggest how to use Phabricator/Arcanist so
>> > that I don't throw my keyboard through my monitor?
>>
>> Please explain your problems, w/o the hyperbole, so people can actually do that.
>>
> It's not hyperbole, but fine.  How do you use it to keep multiple, related changes in order?

You can use parent/child revisions. Phabricator encourages a
patches-based approach with small changes. For me that corresponds to
one commit per code review. When I address code review feedback in a
parent revision I use git's interactive rebase.
What's your workflow for doing this? My current workflow is:

$ vim ...
$ git commit -a -m f
$ git rebase -i
<move the commit I want to upload to the top of the change list>
$ arc diff --update <update ID> --head <sha1 of the commit>

Of course, that doesn't work if the patch relies upon other patches. However, if I keep the patches in order in git, then arc will upload all of the parent changes to that Phab revision.

> The interface for reviewing and responding to reviews is horrific, e.g. quoting text from a review is rather bad, the email it sends is badly formatted and hard to read. How do you make it reasonably useful?

Inline comments are super useful, they can be marked as done and
hidden. I agree that sometimes there's a lot of context when quoting
text, but the format is very simple (similar to e-mail) so it's easy
to trim.
FWIW, the inline comments are fine, but I don't see a way to quote text easily.

> Why can't I *easily* relate changes to each other?

What issues do you experience with parent/child revisions?
It was difficult to find out how to do it. I would expect it to have suggested revisions in the list, but it didn't. It would also be nice to do it through the "arc" tool, but there's no option to do that.

> Why can't I submit through the Phabricator interface, but have to go to the command line, place the change in a new branch, pull to top-of-tree, rebase, and only then push while hoping it doesn't give fail because the tree became out of date? How can I do a rebase through Phabricator?

You can upload patches through
https://reviews.llvm.org/differential/diff/create/<https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_differential_diff_create_&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=frqwLflsBTC4S7ZBA1YhH2N0m5t_d6SbSsjn0E1b2_E&s=tx6sJfZLYG_PvgKOyxpAU160F32vryX4U1MkXuO1zVw&e=>. I personally don't
use arcanist even though I found it pretty useful in the past.

This is part of my issue. The arcanist tool is meant to be used with Phabricator, especially if you develop in a terminal, but people seem to actively avoid using it. I personally find it far too easy to push the wrong changes to a revision.

-bw
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200221/19611319/attachment.html>