[llvm-dev] My first real submission with Phabricator
Paul C. Anagnostopoulos via llvm-dev
llvm-dev at lists.llvm.org
Sat Aug 8 11:29:38 PDT 2020
Git indeed listed the new file as untracked; I did a `git add`; and now it is not listed as untracked. I then added the rest of my changed files and did a 'git diff --cached'. That seems to do the trick. Thanks!
I have read the documentation a couple of times, but it's slow to sink in. I'm not sure what it is about git and my brain.
At 8/8/2020 01:53 PM, Madhur Amilkanthwar wrote:
>I hope you have gone through <https://llvm.org/docs/Contributing.html#how-to-submit-a-patch>https://llvm.org/docs/Contributing.html#how-to-submit-a-patch.
>Generally, I would do 'git add' on the new file. 'git diff' should show me the newly added file. Further, I'd just do 'arc diff' and this should eventually generate a phabricator revision for you. There is UI way to create patches but I personally prefer 'arc' tool for reviews.
>I hope this helps.
>On Sat, Aug 8, 2020 at 11:07 PM Paul C. Anagnostopoulos via llvm-dev <<mailto:llvm-dev at lists.llvm.org>llvm-dev at lists.llvm.org> wrote:
>I am ready to submit my first real submission for review with Phabricator. Please forgive my meager knowledge of Git. I did a 'git diff' to generate the diff file. The contents look good. However, there is one new file, a TableGen test file. How do I get that file included in the diff, or otherwise included in the submission?
>LLVM Developers mailing list
><mailto:llvm-dev at lists.llvm.org>llvm-dev at lists.llvm.org
More information about the llvm-dev