[llvm-dev] My first real submission with Phabricator
Xing GUO via llvm-dev
llvm-dev at lists.llvm.org
Sat Aug 8 11:04:07 PDT 2020
Madhur Amilkanthwar via llvm-dev <llvm-dev at lists.llvm.org>於 2020年8月9日
> Hi Paul,
> I hope you have gone through
> Generally, I would do 'git add' on the new file. 'git diff' should show me
> the newly added file. Further, I'd just do 'arc diff' and this should
> eventually generate a phabricator revision for you. There is UI way to
> create patches but I personally prefer 'arc' tool for reviews.
> I hope this helps.
Yeah, we usually use ‘arc diff’ to create a patch. If you have problem in
installing that tool, you might need to generate the diff with ‘-U9999’ to
include the context for your change which is good for reviewing.
‘git diff HEAD -U9999’
Hope it helps.
> On Sat, Aug 8, 2020 at 11:07 PM Paul C. Anagnostopoulos via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>> I am ready to submit my first real submission for review with
>> Phabricator. Please forgive my meager knowledge of Git. I did a 'git diff'
>> to generate the diff file. The contents look good. However, there is one
>> new file, a TableGen test file. How do I get that file included in the
>> diff, or otherwise included in the submission?
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
> *Disclaimer: Views, concerns, thoughts, questions, ideas expressed in this
> mail are of my own and my employer has no take in it. *
> Thank You.
> Madhur D. Amilkanthwar
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev