[llvm-dev] [RDF] Performance Issues for rdf::Liveness::computePhiInfo()
Krzysztof Parzyszek via llvm-dev
llvm-dev at lists.llvm.org
Thu Apr 30 15:05:28 PDT 2020
I'm actually fixing a correctness problem in that function and the node ordering plays a role in it. I will put more attention to trying to reduce the complexity there.
Krzysztof Parzyszek kparzysz at quicinc.com<mailto:kparzysz at quicinc.com> AI tools development
From: Constable, Scott D <scott.d.constable at intel.com>
Sent: Thursday, April 30, 2020 3:49 PM
To: llvm-dev at lists.llvm.org; Krzysztof Parzyszek <kparzysz at quicinc.com>
Cc: Matthew Riley <mattdr at google.com>; Topper, Craig <craig.topper at intel.com>
Subject: [EXT] [RDF] Performance Issues for rdf::Liveness::computePhiInfo()
I have been working to debug some performance issues in https://reviews.llvm.org/D75936, and I have found that the main issue is rdf::Liveness::computePhiInfo(). Specifically, a single line introduces 20-30% overhead for the entire llc X86 pipeline:
Linux perf shows that the culprit is MachineDominatorTree::dominates(), which is being invoked on nearly every less-than comparison between nodes. The documentation for dominates() reads "dominates -Returns true iff A dominates B. Note that this is not a constant time operation!"
Do you think that this could be fixed? Maybe some memorization could help?
Thanks and regards,
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev