[llvm-dev] whatever happened to this patch?

David Blaikie via llvm-dev llvm-dev at lists.llvm.org
Wed Apr 15 13:52:15 PDT 2020

Generally an author should submit an approved patch. If they do not have
commit access they should ask someone who does (usually the approver) to
commit it on their behalf.

(you generally shouldn't approve patches if you aren't in a position to
have committed the patch without review if it was your own patch - so at
the very least having commit access, but also being sufficiently familiar
with the norms of the part of the project that you're confident committing
without review (this doesn't fully cover all cases, some areas do more
cross-review than others, etc))

On Wed, Apr 15, 2020 at 1:44 PM Andrew Kelley via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> https://reviews.llvm.org/D62475
> It looks like it never got merged, what was the missing step to get this
> landed?
> Regards,
> Andrew
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200415/6a7bc65c/attachment.html>

More information about the llvm-dev mailing list