[llvm-dev] [9.0.0 Release] Release Candidate 4 is here

Hans Wennborg via llvm-dev llvm-dev at lists.llvm.org
Tue Sep 17 00:53:02 PDT 2019


I don't know why it's not a lit builtin, but I think discussing that
in a separate llvm-dev thread is better.

Thanks,
Hans

On Mon, Sep 16, 2019 at 3:08 PM Danila Malyutin
<Danila.Malyutin at synopsys.com> wrote:
>
> Hi,
>
> I was wondering what is the rationale for 'not' utility and if it could be implemented using LIT builtin (like some shell operators). Or at least made independent of LLVM. It’s not really built along with regular tools (it has very limited use contrary to, say, FileCheck) and having it in path is undesirable due to the generic name. This makes testing llvm tools harder. Especially if they don't rely on LLVM directly.
>
> --
> Danila
>
> > -----Original Message-----
> > From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Hans
> > Wennborg via llvm-dev
> > Sent: Monday, September 16, 2019 11:35
> > To: Neil Nelson <nnelson at infowest.com>
> > Cc: llvm-dev <llvm-dev at lists.llvm.org>
> > Subject: Re: [llvm-dev] [9.0.0 Release] Release Candidate 4 is here
> >
> > There are lots of test using "not" so I don't think that's the problem.
> >
> > In any case, thanks for digging out the test failure. I don't think this is severe
> > enough to treat as a blocker though.
> >
> > Thanks,
> > Hans
> >
> > On Fri, Sep 13, 2019 at 10:19 PM Neil Nelson <nnelson at infowest.com>
> > wrote:
> > >
> > > It may be that the 'not' operator is not being found under bash at
> > >
> > > : 'RUN: at line 12';   not
> > >
> > > Perhaps this is would be better as the more commonly seen '!'.
> > >
> > > Neil Nelson
> > >
> > > On 9/13/19 12:12 PM, Neil Nelson via llvm-dev wrote:
> > >
> > > Toward the end of testing.9.0.0-rc4.log.
> > >
> > > Testing: 0 .. 10.. 20.
> > > FAIL: Clang Tools :: clang-tidy/run-clang-tidy.cpp (17057 of 64198)
> > > ******************** TEST 'Clang Tools ::
> > > clang-tidy/run-clang-tidy.cpp' FAILED ********************
> > > Script:
> > > --
> > > : 'RUN: at line 1';   /usr/bin/python /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/llvm.src/tools/clang/tools/extra/test/../test/..
> > /clang-tidy/tool/run-clang-tidy.py --help
> > > : 'RUN: at line 2';   rm -rf /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang-tidy/Output/run-clang-
> > tidy.cpp.tm
> > > p
> > > : 'RUN: at line 3';   mkdir /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang-tidy/Output/run-clang-
> > tidy.cpp.tmp
> > > : 'RUN: at line 4';   echo "[{\"directory\":\".\",\"command\":\"clang++ -c
> > /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extr
> > > a/test/clang-tidy/Output/run-clang-tidy.cpp.tmp/test.cpp\",\"file\":\"
> > > /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Rel
> > > ease+Asserts/llvmCore-9.0.0-rc4.obj/tools/clang/tools/extra/tes
> > > t/clang-tidy/Output/run-clang-tidy.cpp.tmp/test.cpp\"}]" | sed -e
> > > 's/\\/\\\\/g' >
> > > /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Rel
> > > ease+Asserts/llvmCore-9.0.0-rc4.obj/tools/clang/too
> > > ls/extra/test/clang-tidy/Output/run-clang-
> > tidy.cpp.tmp/compile_commands.json
> > > : 'RUN: at line 5';   echo "Checks: '-*,modernize-use-auto'" >
> > /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang
> > > -tidy/Output/run-clang-tidy.cpp.tmp/.clang-tidy
> > > : 'RUN: at line 6';   echo "WarningsAsErrors: '*'" >>
> > /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang-tidy/Out
> > > put/run-clang-tidy.cpp.tmp/.clang-tidy
> > > : 'RUN: at line 7';   echo "CheckOptions:" >>
> > /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang-tidy/Output/run-
> > > clang-tidy.cpp.tmp/.clang-tidy
> > > : 'RUN: at line 8';   echo "  - key:             modernize-use-
> > auto.MinTypeNameLength" >> /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/c
> > > lang/tools/extra/test/clang-tidy/Output/run-clang-tidy.cpp.tmp/.clang-tidy
> > > : 'RUN: at line 9';   echo "    value:           '0'" >>
> > /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang-tidy/
> > > Output/run-clang-tidy.cpp.tmp/.clang-tidy
> > > : 'RUN: at line 10';   cp "/home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/llvm.src/tools/clang/tools/extra/test/clang-
> > tidy/run-clang-tidy.cpp" "/home/nnelson/Documents/llvm-project/llvm/util
> > > s/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang-tidy/Output/run-clang-
> > tidy.cpp.tmp/test.cpp"
> > > : 'RUN: at line 11';   cd "/home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang-tidy/Output/run-clang-
> > tidy.cpp.tmp"
> > > : 'RUN: at line 12';   not /usr/bin/python /home/nnelson/Documents/llvm-
> > project/llvm/utils/release/rc4/llvm.src/tools/clang/tools/extra/test/../test/..
> > /clang-tidy/tool/run-clang-tidy.py "/home/nnelson/Do
> > > cuments/llvm-
> > project/llvm/utils/release/rc4/Phase3/Release+Asserts/llvmCore-9.0.0-
> > rc4.obj/tools/clang/tools/extra/test/clang-tidy/Output/run-clang-
> > tidy.cpp.tmp/test.cpp"
> > > --
> > > Exit Code: 1
> > >
> > > Command Output (stdout):
> > > --
> > > usage: run-clang-tidy.py ...... [not included]
> > >
> > > ********************
> > > Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
> > >
> > > 15 warning(s) in tests.
> > > Testing Time: 4923.38s
> > > ********************
> > > Failing Tests (1):
> > >     Clang Tools :: clang-tidy/run-clang-tidy.cpp
> > >
> > >   Expected Passes    : 62200
> > >   Expected Failures  : 256
> > >   Unsupported Tests  : 1741
> > >   Unexpected Failures: 1
> > > make[3]: *** [CMakeFiles/check-all.dir/build.make:58:
> > > CMakeFiles/check-all] Error 1
> > > make[3]: Target 'CMakeFiles/check-all.dir/build' not remade because of
> > errors.
> > > make[2]: *** [CMakeFiles/Makefile2:354: CMakeFiles/check-all.dir/all]
> > > Error 2
> > > make[1]: *** [CMakeFiles/Makefile2:361: CMakeFiles/check-all.dir/rule]
> > > Error 2
> > > make[1]: Target 'check-all' not remade because of errors.
> > > make: *** [Makefile:238: check-all] Error 2 [Release+Asserts Phase3]
> > > check-all failed
> > >
> > > Neil Nelson
> > >
> > > On 9/13/19 2:26 AM, Hans Wennborg wrote:
> > >
> > > Thanks! I'll get this posted on the web site.
> > >
> > > The "Performing Test ... failed to compile" failures from cmake are
> > > not interesting. But could you look in the log file and try to see
> > > what were the tests that failed in the "check-all" step?
> > >
> > > On Thu, Sep 12, 2019 at 4:39 PM Neil Nelson via llvm-dev
> > > <llvm-dev at lists.llvm.org> wrote:
> > >
> > > Xubuntu/Ubuntu 19.04, uploaded
> > >
> > > sha256sum clang+llvm-9.0.0-rc4-x86_64-pc-linux-gnu.tar.xz
> > > 47a204e1f6d32b443001acb97e65b603de8eec9b493ca5b1f66c88a367d605dc
> > >
> > > grep fail in logs
> > > deferred_errors.log:[Release+Asserts Phase3] check-all failed
> > > testing.9.0.0-rc4.log:-- Performing Test
> > HAVE_THREAD_SAFETY_ATTRIBUTES
> > > -- failed to compile
> > > testing.9.0.0-rc4.log:-- Performing Test HAVE_GNU_POSIX_REGEX --
> > > failed to compile testing.9.0.0-rc4.log:[Release+Asserts Phase3]
> > > check-all failed
> > > testing.9.0.0-rc4.log:-- Performing Test
> > HAVE_THREAD_SAFETY_ATTRIBUTES
> > > -- failed to compile
> > > testing.9.0.0-rc4.log:-- Performing Test HAVE_GNU_POSIX_REGEX --
> > > failed to compile
> > >
> > > Neil Nelson
> > >
> > > On 9/10/19 4:26 AM, Hans Wennborg via llvm-dev wrote:
> > >
> > > Hello again,
> > >
> > > 9.0.0-rc4 was just tagged from the release_90 branch at r371490. In
> > > the Git monorepo, it's tagged as llvmorg-9.0.0-rc4.
> > >
> > > Source code and docs are available at
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__prereleases.llvm.
> > > org_9.0.0_-
> > 23rc4&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=YgdxWMcdqQPlU9EdetI
> > -xI79G7ouw9_Us0dFsZnFQYU&m=rNIYSRrtqE3Aga6DsoPc9Q5vShaQEnYJ-yO-
> > 0fCe5Ag&s=APEx2KcefXISQH7_CcfNuSCu-QHw5qZsaj7cqpZynG4&e=
> > Binaries will be added as they become available.
> > >
> > > There are not a lot of changes from rc3 to rc4, and there are again no
> > > open release blockers, so I'm hoping this will be the last release
> > > candidate and that we can tag the final release soon.
> > >
> > > Please file bug reports for any issues you find, marking them blocking
> > > of
> > > https://urldefense.proofpoint.com/v2/url?u=https-
> > 3A__llvm.org_PR42474&
> > > d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=YgdxWMcdqQPlU9EdetI-
> > xI79G7ouw9_Us0
> > > dFsZnFQYU&m=rNIYSRrtqE3Aga6DsoPc9Q5vShaQEnYJ-yO-
> > 0fCe5Ag&s=skchdIELq4oG
> > > bvJnnBaqylg5YeIQEjyNocpqZpZbQbc&e=
> > >
> > > Release testers, please run the test script, share your results, and
> > > upload binaries.
> > >
> > > Thanks,
> > > Hans
> > > _______________________________________________
> > > LLVM Developers mailing list
> > > llvm-dev at lists.llvm.org
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cg
> > > i-2Dbin_mailman_listinfo_llvm-
> > 2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&
> > > r=YgdxWMcdqQPlU9EdetI-
> > xI79G7ouw9_Us0dFsZnFQYU&m=rNIYSRrtqE3Aga6DsoPc9Q
> > > 5vShaQEnYJ-yO-0fCe5Ag&s=zCfplHjk8Jrn4RzDPrTMkUYl-AzX7hlqF-
> > __E8vxtkI&e=
> > >
> > > _______________________________________________
> > > LLVM Developers mailing list
> > > llvm-dev at lists.llvm.org
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cg
> > > i-2Dbin_mailman_listinfo_llvm-
> > 2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&
> > > r=YgdxWMcdqQPlU9EdetI-
> > xI79G7ouw9_Us0dFsZnFQYU&m=rNIYSRrtqE3Aga6DsoPc9Q
> > > 5vShaQEnYJ-yO-0fCe5Ag&s=zCfplHjk8Jrn4RzDPrTMkUYl-AzX7hlqF-
> > __E8vxtkI&e=
> > >
> > >
> > > _______________________________________________
> > > LLVM Developers mailing list
> > > llvm-dev at lists.llvm.org
> > > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cg
> > > i-2Dbin_mailman_listinfo_llvm-
> > 2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&
> > > r=YgdxWMcdqQPlU9EdetI-
> > xI79G7ouw9_Us0dFsZnFQYU&m=rNIYSRrtqE3Aga6DsoPc9Q
> > > 5vShaQEnYJ-yO-0fCe5Ag&s=zCfplHjk8Jrn4RzDPrTMkUYl-AzX7hlqF-
> > __E8vxtkI&e=
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-
> > 2Dbin_mailman_listinfo_llvm-
> > 2Ddev&d=DwIGaQ&c=DPL6_X_6JkXFx7AXWqB0tg&r=YgdxWMcdqQPlU9Ede
> > tI-xI79G7ouw9_Us0dFsZnFQYU&m=rNIYSRrtqE3Aga6DsoPc9Q5vShaQEnYJ-
> > yO-0fCe5Ag&s=zCfplHjk8Jrn4RzDPrTMkUYl-AzX7hlqF-__E8vxtkI&e=


More information about the llvm-dev mailing list