[llvm-dev] Committing with git

David Greene via llvm-dev llvm-dev at lists.llvm.org
Tue Oct 29 11:31:06 PDT 2019

"Sachkov, Alexey via llvm-dev" <llvm-dev at lists.llvm.org> writes:

>> At the dev meeting I heard Doug Gregor say something like, "what kind of dirty animals are you, you just push directly to master!?" Based on that, I think other communities may set up workflows where they push branches to places, and some automation rebases and updates master asynchronously, optionally conditioned on some (light) testing or approval.
> Someone has already mentioned rust-lang/rust GitHub project in other thread related to GitHub migration: from their contribution guide (https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#pull-requests):
>> After someone has reviewed your pull request, they will leave an annotation on the pull request with an r+. It will look something like this:
>> @bors r+
>> This tells @bors, our lovable integration bot, that your pull request has been approved. The PR then enters the merge queue, where @bors will run all the tests on every platform we support. If it all works out, @bors will merge your code into master and close the pull request.
>> Depending on the scale of the change, you may see a slightly different form of r+:
>> @bors r+ rollup
>> The additional rollup tells @bors that this change is eligible for to be "rolled up". Changes that are rolled up are tested and merged at the same time, to speed the process up. Typically only small changes that are expected not to conflict with one another are rolled up.
> Just an idea of possible automation which will contribute to stability of master on merges

+1, though I don't know if the volume of commits will be an issue.  The
queue could get backed up pretty far unless lots of things get rolled up
together.  The tradeoff of that is less precision in identifying
breaking changes.


More information about the llvm-dev mailing list