[llvm-dev] [cfe-dev] How soon after the GitHub migration should committing with git-llvm become optional?
Tom Stellard via llvm-dev
llvm-dev at lists.llvm.org
Tue Oct 15 12:16:51 PDT 2019
On 10/15/2019 11:51 AM, Lei Huang wrote:
> On 10/15/2019 12:20 AM, Roman Lebedev wrote:
>> On Tue, Oct 15, 2019 at 10:14 AM Tom Stellard via cfe-dev
>> <cfe-dev at lists.llvm.org> wrote:
>>> I mentioned this in my email last week, but I wanted to start a new
>>> thread to get everyone's input on what to do about the git-llvm script
>>> after the GitHub migration.
>>> The original plan was to require the use of the git-llvm script when
>>> committing to GitHub even after the migration was complete.
>>> The reason we decided to do this was so that we could prevent developers
>>> from accidentally pushing merge commits and making the history non-linear.
>>> Just in the last week, the GitHub team completed the "Require Linear
>>> History" branch protection, which means we can now enforce linear
>>> history server side and do not need the git-llvm script to do this.
>> What about prevention of new branch creation?
>> From the bugzilla disscussion, i gather that is not possible to do via github?
> Correct, but the git-llvm script can only prevent people from creating new
> branches if they use the script. Someone could still create a new branch
> using `git push`. We can use branch protections to prevent pushing to
> existing branches but not for preventing new ones.
> Maybe I missed something, but the git doc seem to indicate we can setup a server
> side pre-receive hook. Can we not use this to prevent users from creating a new branch?
GitHub only supports pre-receive hooks in their Enterprise Server edition,
which isn't a good option for us, because we would need to self-host it.
> - Lei
>>> With this new development, the question I have is when should the
>>> git-llvm script become optional? Should we make it optional immediately,
>>> so that developers can push directly using vanilla git from day 1, or should we
>>> wait a few weeks/months until things have stabilized to make it optional?
>>> cfe-dev mailing list
>>> cfe-dev at lists.llvm.org
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
More information about the llvm-dev