[llvm-dev] [RFC] Create llvm/lib/Frontend

Doerfert, Johannes via llvm-dev llvm-dev at lists.llvm.org
Mon Nov 25 10:36:34 PST 2019


Sorry for my delay.

On 11/19, Chris Lattner wrote:
> 
> 
> > On Nov 19, 2019, at 9:04 AM, Doerfert, Johannes <jdoerfert at anl.gov> wrote:
> > 
> >>> 
> >>> First, I tried to place the OpenMP-IR-Builder into llvm/IR, right next
> >>> to the llvm::IRBuilder, but it would soon introduce a dependence on
> >>> other libraries (first TransformUtils) [2].
> >> 
> >> I think it is a great idea to share the OpenMP lowering code, but I’m
> >> concerned about the name 'lib/Frontend’.  This is a very broad name
> >> and there are lots of things that “could be useful for frontends” -
> >> and a lot of definitions of what a “frontend" is.
> > 
> > Fair point. I'm open to suggestions wrt. the name. FWIW, the name was
> > suggested because it was not only supposed to be OpenMP stuff (soon).
> 
> What are the other things?  Naming is often helped by having examples
> from the broader pool that will shape this.  It will also be helpful
> to understand what would be “in” vs “out” of scope for this over time.

One is toolchain handling, which should be available to the linker
plugin so we can do fat binary linking without going through the clang
driver.

There is a desire to share driver code in here as well, Peter and Mark
can probably elaborate on that.

I predict we find more use cases over time.

> >> WDYT about naming it something like "lib/OpenMPGen” and
> >> generalizing/renaming it later when the scope is more clear?
> > 
> > I can do that. It was also proposed to do "lib/Frontend/OpenMP" or
> > something similar. Would that help or would you prefer not to have the
> > top level "Frontend" until we actually move other things?
> 
> Sure,

So `lib/Frontend/OpenMP` for the OpenMP specific part seems to be a
popular option. I'd like to go ahead with this soon, please let me know
if there is disagreement. FWIW, it should be easy to rename/move the
code later anyway.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191125/7fccd157/attachment.sig>


More information about the llvm-dev mailing list