[llvm-dev] [RFC] High-Level Code-Review Documentation Update

David Greene via llvm-dev llvm-dev at lists.llvm.org
Wed Nov 20 11:36:36 PST 2019


Nicolai Hähnle via llvm-dev <llvm-dev at lists.llvm.org> writes:

> Of course, this is usually not an issue in LLVM today because we're so
> bad at reviewing code in general :) If you've waited on a review for a
> month and pinged people several times, then by all means feel free to
> commit immediately after getting a LGTM.

I feel like something should be spelled out about what to do if no
responses are given to a patch.  I've had that happen multiple times,
pinging once a week for a month or more.  What is the author supposed to
do?

                        -David


More information about the llvm-dev mailing list