[llvm-dev] Enable Contributions Through Pull-request For LLVM
David Greene via llvm-dev
llvm-dev at lists.llvm.org
Fri Nov 8 09:29:26 PST 2019
Philip Reames via llvm-dev <llvm-dev at lists.llvm.org> writes:
> Weak -1 in general. I'm not strongly opposed, but I see very little
> value in this migration and a lot of headache. Others have explained
> this well, so I'll mostly skip that. I particular dislike the assumed
> fork model; I work in patches, so that's a ton of overhead process wise.
Can you explain this a bit more? The way I anticipate doing this:
1. Create fork once for all time
2. Set a remote for the fork in my local clone once for all time
while ((I am employed or financially independent) and working on LLVM)
1. Make a commit
2. Push to fork remote
3. Open PR (probably right in emacs using Magit)
4. Respond to comments, push further commits, squash as needed, etc.
5. Declare done and request CI/merge
I would never delete the fork or the fork remote.
> One exception for me would be docs. If we could open pull requests -
> and possibly the web-edit tool for folks with commit access? - for the
> docs subtree I could see a lot of advantage in making those easy for new
> contributors to update. It might also be a good proving ground for the
> workflow as a whole.
That's a really great idea!
More information about the llvm-dev