[llvm-dev] Committing with git

Jacob Carlborg via llvm-dev llvm-dev at lists.llvm.org
Mon Nov 4 11:41:02 PST 2019

On 2019-11-03 18:42, Chris Bieneman via llvm-dev wrote:

> For a project as large as LLVM (and even many much smaller) there is a balance between how much testing you can do on a PR without disrupting development and how long that testing takes. There are some LLVM testing configurations that take many hours to run, and if every change was validated by those tests development would slow to a halt.

Perhaps not the full test suite needs to be run on every PR.

> I think there is a lot of balancing act we're going to have to figure out here. If we invalidate the test results after every merge that could cause a huge backlog of unrelated changes to require re-testing. One thing we would likely need in any PR testing strategy is a way to determine which project(s) to build and test. Since the mono-repo has all projects together, and many of them are largely decoupled the PR testing infrastructure would need to take that into account. For example, a change to libcxxabi shouldn't need LLVM to build and pass tests, but it should probably build and test libcxx.

Yeah, that's a downside with the mono-repo approach. I still don't 
understand why that was chosen.

/Jacob Carlborg

More information about the llvm-dev mailing list