[llvm-dev] Comments on GitHub commits?

Mehdi AMINI via llvm-dev llvm-dev at lists.llvm.org
Fri Nov 1 20:26:05 PDT 2019

On Wed, Oct 30, 2019 at 10:59 PM David Zarzycki via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> On Oct 30, 2019, at 5:57 PM, Tom Stellard via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
> On 10/30/2019 03:09 AM, Stephan Bergmann via llvm-dev wrote:
> You can apparently leave comments on GitHub commits (instead of commenting
> at Phabricator, or directly sending a reply to the relevant commit mailing
> list and relevant CCs).  I once accidentally did that myself (<
> https://github.com/llvm/llvm-project/commit/4a6861a7e5b59be24a09b8b9782255d028e7aade#commitcomment-35540755>)
> and now (presumably because I'm member of some GitHub group) got mail about
> <
> https://github.com/llvm/llvm-project/commit/2724d9e12960cc1d93eeabbfc9aa1bffffa041cc#commitcomment-35724925
> >.
> Do we want to allow such comments?
> I think we would like this disabled, but I don't think it's possible.
> Or at least I haven't found a way to do it yet.
> Not automatically as far as I can tell. One can manually “lock the
> conversation” on a commit but that’s about it.
> From what I’ve seen on other projects, comments on raw git commits are
> rare and self-limiting. The only reasonable responses are “okay”, “okay,
> file a bug”, and “okay, please submit a patch”. I also haven’t verified
> this, but I suspect only the commit author gets notified, which prevents
> idle people from piling onto to the conversation.
Watchers of the repo get the comments (just like pull-requests).

I suspect that moving to a system where people are watching the repository
instead of subscribing to the mailing-list is likely unavoidable at some

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191101/3f673af6/attachment.html>

More information about the llvm-dev mailing list