[llvm-dev] Fix builds on MacOS Mojave [patch]

[Eli Friedman via llvm-dev]

On an OS X install with Xcode, /opt/ is not expected to contain anything in particular; it doesn't make sense to hard-code it into the LLVM build system.

Are you trying to use homebrew to build LLVM?

-Eli

> -----Original Message-----
> From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Mark Murray
> via llvm-dev
> Sent: Wednesday, May 1, 2019 8:48 AM
> To: llvm-dev at lists.llvm.org
> Subject: [EXT] [llvm-dev] Fix builds on MacOS Mojave [patch]
> 
> Hi!
> 
> I get build failures on Macos 10.14 Mojave.
> 
> How-to-repeat:
> $ git clone <llvm-project>
> $ cd llvm-project && mkdir build && cd build
> $ cmake -G"Unix Makefiles" ../llvm
> $ make # or "make -j${N}"
> :
> Building
> :
> In file included from /Users/marmur02/git/llvm-
> project/llvm/lib/WindowsManifest/WindowsManifestMerger.cpp:20:
> In file included from /opt/local/include/libxml2/libxml/xmlreader.h:14:
> In file included from /opt/local/include/libxml2/libxml/tree.h:1307:
> In file included from /opt/local/include/libxml2/libxml/xmlmemory.h:218:
> In file included from /opt/local/include/libxml2/libxml/threads.h:35:
> In file included from /opt/local/include/libxml2/libxml/globals.h:18:
> In file included from /opt/local/include/libxml2/libxml/parser.h:810:
> In file included from /opt/local/include/libxml2/libxml/encoding.h:31:
> /opt/local/include/unicode/ucnv.h:52:10: fatal error: 'unicode/ucnv_err.h' file
> not found
> #include "unicode/ucnv_err.h"
>          ^~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> 
> A fix is attached.
> 
> Thanks!
> 
> M
> 
> Mark Murray Staff Software Engineer | Arm
> . . . . . . . . . . . . . . . . . . . . . . . . . . .
> arm.com <http://www.arm.com>
> 
> 
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended recipient,
> please notify the sender immediately and do not disclose the contents to any
> other person, use it for any purpose, or store or copy the information in any
> medium. Thank you.