[llvm-dev] [RFC] change .gitignore for monorepo

Alex L via llvm-dev llvm-dev at lists.llvm.org
Wed Jul 17 10:19:08 PDT 2019


On Wed, 17 Jul 2019 at 10:07, Peter Collingbourne via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> I proposed this before in https://reviews.llvm.org/D57400. At the time
> there was some opposition to the proposal so I didn't pursue it further,
> but I still think it would be very useful to do something like that so that
> I don't have to continue to maintain my own exclude file.
>
> Peter
>
> On Wed, Jul 17, 2019 at 9:59 AM Tom Stellard via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
>> On 07/17/2019 09:45 AM, Zakharin, Vyacheslav P via llvm-dev wrote:
>> > Hello,
>> >
>> >
>> >
>> > My team is using some non-llvm projects along with llvm-project
>> monorepo.  The projects are checked out to the top level of llvm-project,
>> and ‘git status’ would complain about them unless we add them to
>> .gitignore.  We do not really want to change llorg’s .gitignore on our
>> side, so may we propose changing llorg’s .gitignore to ignore all top-level
>> files/directories that are not explicitly listed?  Something along the
>> lines:
>> >
>> > /*
>> >
>> > !/clang
>> >
>> > !/clang-tools-extra
>> >
>> > !/compiler-rt
>> >
>> > …
>> >
>> >
>> >
>> > This will require updating .gitignore every time a new top-level entry
>> is added into llvm-project monorepo, which should not be a big deal.
>> Please let me know if I can proceed with a review request.
>>
>
Hi,

This might work reasonably well for the upstream llvm-project. However, do
you have any thoughts about how downstream llvm-project monorepos that have
other top-level directories in a their fork of llvm-project would handle
this situation? Would all of them have to add a downstream .gitignore rule
for their new top-level directory? That doesn't seem ideal to me.

Thanks,
Alex


> >
>> >
>>
>> These seems like a good concept to me, but I'm not a git expert,
>> so I'm unsure of what potential problems (if any) this might cause.
>>
>> I think this is worth submitting a review for.
>>
>> -Tom
>>
>> >
>> > Thanks,
>> >
>> > Slava
>> >
>> >
>> >
>> >
>> >
>> > _______________________________________________
>> > LLVM Developers mailing list
>> > llvm-dev at lists.llvm.org
>> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>> >
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
>
>
> --
> --
> Peter
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20190717/9fa964de/attachment.html>


More information about the llvm-dev mailing list