[llvm-dev] [RFC] migrating past C++11

Alex Bradbury via llvm-dev llvm-dev at lists.llvm.org
Thu Jan 31 14:03:46 PST 2019


On Tue, 29 Jan 2019 at 21:05, JF Bastien via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> The patch is about ready to land, which means any older compiler will soft-error (which you can turn off with LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN). I think we should then cherry-pick the patch to the LLVM 8 branch.
>
> The last remaining issue are the buildbots. I audited *all* bots in http://lab.llvm.org:8011/buildslaves (there's so many!). Some of them are down, I therefore have no idea what they run. Here are the bots that will definitely break, with their maintainers:
>
> Galina Kistanova <gkistanova at gmail.com>
> am1i-slv1 -- gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
> as-bldslv4 -- Microsoft (R) Visual Studio (R) 2015 (14.0)
> ps4-buildslave2 -- Microsoft (R) Visual Studio (R) 2015 (14.0)
>
> Hexagon QA <llvm.buildmaster at quicinc.com>
> hexagon-build-02 -- gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
> hexagon-build-03 -- gcc (Ubuntu 4.9.2-10ubuntu13) 4.9.2
>
> Vitaly Buka <vitalybuka at google.com>
> sanitizer-buildbot6 -- gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
>
> Reid Kleckner <rnk at google.com>
> sanitizer-windows -- Microsoft (R) Visual Studio (R) 2015 (14.0)
>
> Ilia Taraban <mstester.llvm at gmail.com>
> windows7-buildbot -- Microsoft (R) Visual Studio (R) 2015 (14.0)
>
>
> The maintainers have 3 options:
>
> 1. Pass LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN to their bot, suffer breakage later.
> 2. Update the bot to a newer compiler version.
> 3. Entirely turn down the bot.
>
> I’ve emailed the maintainers and some have already responded. Once all bots are in a good state I’ll commit the patch (unless someone else chimes in with new information).

Did anyone pick option 1)? If I understand correctly, we probably want
to ensure that at least some bots do this, so we can ensure an old
compiler + LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN build actually remains
functional up until the point support for the old compiler is actually
removed.

Best,

Alex


More information about the llvm-dev mailing list