[llvm-dev] Flang landing in the monorepo

[Peter Waller via llvm-dev]

On 18/12/2019 21:49, Eric Christopher wrote:
> Yes, I looked through those sources and a number of my questions 
> around which clang versions have been supported and directory 
> structure. I think the only difference is removing the direct 
> questions about earlier flang, but I still don't see code generation 
> or uses of llvm libraries that would conform to "written in the style 
> of LLVM and clang". Can you perhaps point me to where I'm missing 
> these things?
I can't speak with authority on all of these issues.

In terms of clang versions, I understand that clang version 7 and 8 are 
currently supported. We would expect it to work with newer LLVM 
versions, and
the readme is currently out of date. The intent is that it will work 
with all branches of LLVM and the community will build up CI to protect 
this.

It's worth mentioning that merging flang in at this point does not 
affect the existing LLVM build in any way. Patches to integrate the 
build system are expected in the near future, and be subject to the 
normal LLVM code review processes.

I understand that code generation is a work in progress and is expected 
to start landing in the not too distant future. Other people (Steve 
Scalpone, cc'd, and others) can perhaps speak to this more than me.

In terms of using LLVM ADTs, etc, I expect that once flang is part of 
the monorepo, there will be a greater usage of those things.
> Chris's earlier acceptance aside I don't see any evidence of code 
> review as part of that and so I'd expect we'd see more here.
Code review has been happening all along in the the f18 github repository:
https://github.com/flang-compiler/f18/pulls

I am operating on the assumption that the code will land with no 
additional review by members of the LLVM community, and future code 
review will happen with the same mechanisms that the wider LLVM project use.

Regards,

- Peter