[llvm-dev] [PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h
Jay Foad via llvm-dev
llvm-dev at lists.llvm.org
Fri Dec 13 06:45:39 PST 2019
Yes, it works for me. Thank you!
Jay.
On Wed, 11 Dec 2019 at 22:09, Doerfert, Johannes <jdoerfert at anl.gov> wrote:
>
> Jay, Hiroshi, did [0] resolve the problem you've seen.
>
> [0] https://github.com/llvm/llvm-project/commit/d23c61490c282a7a8f29aaa5c021cbfdaf87fb6f
>
> On 12/10, Doerfert, Johannes wrote:
> > I think the problem is that only clang has a dependence on the new
> > library and when you check LLVM without building clang it does not exist
> > yet. I will commit a LLVM patch today that will cause LLVM to have a
> > dependence on the new library as well. That should, I hope, fix the
> > problem.
> >
> >
> > On 12/10, Hiroshi Yamauchi wrote:
> > > This seems to be happening to me, too. I think this happens for me on
> > > "ninja check-llvm" in a clean build. Let me know if you need more info.
> > >
> > > On Tue, Dec 10, 2019 at 2:22 PM Doerfert, Johannes via llvm-dev <
> > > llvm-dev at lists.llvm.org> wrote:
> > >
> > > > Hi Jay,
> > > >
> > > > I am not sure why this happens.
> > > > Can you give me some information so I can reproduce it:
> > > > Is this happens for a clean build?
> > > > Is Clang build as well?
> > > >
> > > > I think the SYSTEM_LIBS macro doesn't contain the new
> > > > libLLVMFrontendOpenMP but I don't know why.
> > > >
> > > > Thanks,
> > > > Johannes
> > > >
> > > >
> > > > On 12/10, Jay Foad wrote:
> > > > > Johannes,
> > > > >
> > > > > This patch seems to be causing test failures when I just do "ninja
> > > > > check", without running "ninja" or "ninja all" first.
> > > > >
> > > > > $ CC=clang CXX=clang++ cmake -G Ninja ~/git/llvm-project/llvm
> > > > > -DLLVM_USE_LINKER=lld -DLLVM_PARALLEL_LINK_JOBS=4
> > > > > -DCMAKE_BUILD_TYPE=Release -DLLVM_TARGETS_TO_BUILD=X86 && ninja check
> > > > > [...]
> > > > > FAIL: LLVM :: tools/llvm-config/system-libs.test (32608 of 34640)
> > > > > ******************** TEST 'LLVM :: tools/llvm-config/system-libs.test'
> > > > > FAILED ********************
> > > > > Script:
> > > > > --
> > > > > : 'RUN: at line 1'; /home/jayfoad2/tmp/bin/llvm-config --link-static
> > > > > --system-libs 2>&1 | /home/jayfoad2/tmp/bin/FileCheck
> > > > >
> > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/system-libs.test
> > > > > --
> > > > > Exit Code: 1
> > > > >
> > > > > Command Output (stderr):
> > > > > --
> > > > >
> > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/system-libs.test:4:8:
> > > > > error: CHECK: expected string not found in input
> > > > > CHECK: -l
> > > > > ^
> > > > > <stdin>:1:1: note: scanning from here
> > > > > llvm-config: error: missing:
> > > > /home/jayfoad2/tmp/lib/libLLVMFrontendOpenMP.a
> > > > > ^
> > > > >
> > > > > --
> > > > >
> > > > > ********************
> > > > > FAIL: LLVM :: tools/llvm-config/booleans.test (32612 of 34640)
> > > > > ******************** TEST 'LLVM :: tools/llvm-config/booleans.test'
> > > > > FAILED ********************
> > > > > Script:
> > > > > --
> > > > > : 'RUN: at line 2'; /home/jayfoad2/tmp/bin/llvm-config
> > > > > --assertion-mode 2>&1 | /home/jayfoad2/tmp/bin/FileCheck
> > > > > --check-prefix=CHECK-ONOFF
> > > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test
> > > > > : 'RUN: at line 3'; /home/jayfoad2/tmp/bin/llvm-config
> > > > > --has-global-isel 2>&1 | /home/jayfoad2/tmp/bin/FileCheck
> > > > > --check-prefix=CHECK-ONOFF
> > > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test
> > > > > : 'RUN: at line 9'; /home/jayfoad2/tmp/bin/llvm-config --has-rtti
> > > > > 2>&1 | /home/jayfoad2/tmp/bin/FileCheck --check-prefix=CHECK-YESNO
> > > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test
> > > > > : 'RUN: at line 15'; /home/jayfoad2/tmp/bin/llvm-config --build-mode
> > > > > 2>&1 | /home/jayfoad2/tmp/bin/FileCheck
> > > > > --check-prefix=CHECK-BUILD-MODE
> > > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test
> > > > > : 'RUN: at line 20'; /home/jayfoad2/tmp/bin/llvm-config
> > > > > --build-system 2>&1 | /home/jayfoad2/tmp/bin/FileCheck
> > > > > --check-prefix=CHECK-BUILD-SYSTEM
> > > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test
> > > > > : 'RUN: at line 25'; /home/jayfoad2/tmp/bin/llvm-config
> > > > > --shared-mode 2>&1 | /home/jayfoad2/tmp/bin/FileCheck
> > > > > --check-prefix=CHECK-SHARED-MODE
> > > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test
> > > > > --
> > > > > Exit Code: 1
> > > > >
> > > > > Command Output (stderr):
> > > > > --
> > > > >
> > > > /home/jayfoad2/git/llvm-project/llvm/test/tools/llvm-config/booleans.test:27:24:
> > > > > error: CHECK-SHARED-MODE-NOT: excluded string found in input
> > > > > CHECK-SHARED-MODE-NOT: error:
> > > > > ^
> > > > > <stdin>:3:14: note: found here
> > > > > llvm-config: error: missing:
> > > > /home/jayfoad2/tmp/lib/libLLVMFrontendOpenMP.a
> > > > > ^~~~~~
> > > > >
> > > > > --
> > > > >
> > > > > ********************
> > > > >
> > > > > Testing Time: 69.42s
> > > > > ********************
> > > > > Failing Tests (2):
> > > > > LLVM :: tools/llvm-config/booleans.test
> > > > > LLVM :: tools/llvm-config/system-libs.test
> > > > >
> > > > > Expected Passes : 19544
> > > > > Expected Failures : 49
> > > > > Unsupported Tests : 15045
> > > > > Unexpected Failures: 2
> > > > > FAILED: test/CMakeFiles/check-llvm
> > > > > cd /home/jayfoad2/tmp/test && /usr/bin/python
> > > > > /home/jayfoad2/tmp/./bin/llvm-lit -sv /home/jayfoad2/tmp/test
> > > > > ninja: build stopped: subcommand failed.
> > > > >
> > > > >
> > > > >
> > > > > $ ninja && ninja check
> > > > > [41/41] Linking CXX executable bin/llvm-stress
> > > > > [0/1] Running the LLVM regression tests
> > > > >
> > > > > Testing Time: 69.02s
> > > > > Expected Passes : 19547
> > > > > Expected Failures : 49
> > > > > Unsupported Tests : 15044
> > > > >
> > > > >
> > > > >
> > > > > Could you take a look please?
> > > > >
> > > > > Thanks,
> > > > > Jay.
> > > > >
> > > > > On Tue, 10 Dec 2019 at 06:19, Johannes Doerfert via Phabricator via
> > > > > llvm-commits <llvm-commits at lists.llvm.org> wrote:
> > > > > >
> > > > > > This revision was automatically updated to reflect the committed
> > > > changes.
> > > > > > Closed by commit rGeb3e81f43f01: [OpenMP][NFCI] Introduce
> > > > llvm/IR/OpenMPConstants.h (authored by jdoerfert).
> > > > > >
> > > > > > Changed prior to commit:
> > > > > > https://reviews.llvm.org/D69853?vs=232987&id=233003#toc
> > > > > >
> > > > > > Repository:
> > > > > > rG LLVM Github Monorepo
> > > > > >
> > > > > > CHANGES SINCE LAST ACTION
> > > > > > https://reviews.llvm.org/D69853/new/
> > > > > >
> > > > > > https://reviews.llvm.org/D69853
> > > > > >
> > > > > > Files:
> > > > > > clang/include/clang/AST/OpenMPClause.h
> > > > > > clang/include/clang/AST/StmtOpenMP.h
> > > > > > clang/include/clang/Basic/OpenMPKinds.def
> > > > > > clang/include/clang/Basic/OpenMPKinds.h
> > > > > > clang/lib/AST/CMakeLists.txt
> > > > > > clang/lib/AST/OpenMPClause.cpp
> > > > > > clang/lib/AST/StmtOpenMP.cpp
> > > > > > clang/lib/Basic/OpenMPKinds.cpp
> > > > > > clang/lib/CodeGen/CGOpenMPRuntime.cpp
> > > > > > clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
> > > > > > clang/lib/CodeGen/CGStmtOpenMP.cpp
> > > > > > clang/lib/CodeGen/CodeGenFunction.h
> > > > > > clang/lib/Parse/CMakeLists.txt
> > > > > > clang/lib/Parse/ParseOpenMP.cpp
> > > > > > clang/lib/Sema/CMakeLists.txt
> > > > > > clang/lib/Sema/SemaOpenMP.cpp
> > > > > > clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
> > > > > > clang/lib/Sema/TreeTransform.h
> > > > > > clang/lib/Serialization/ASTWriter.cpp
> > > > > > clang/lib/Serialization/ASTWriterStmt.cpp
> > > > > > llvm/include/llvm/Frontend/OpenMP/OMPConstants.h
> > > > > > llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
> > > > > > llvm/lib/CMakeLists.txt
> > > > > > llvm/lib/Frontend/CMakeLists.txt
> > > > > > llvm/lib/Frontend/LLVMBuild.txt
> > > > > > llvm/lib/Frontend/OpenMP/CMakeLists.txt
> > > > > > llvm/lib/Frontend/OpenMP/LLVMBuild.txt
> > > > > > llvm/lib/Frontend/OpenMP/OMPConstants.cpp
> > > > > > llvm/lib/LLVMBuild.txt
> > > > > >
> > > > > > _______________________________________________
> > > > > > llvm-commits mailing list
> > > > > > llvm-commits at lists.llvm.org
> > > > > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> > > >
> > > > --
> > > >
> > > > Johannes Doerfert
> > > > Researcher
> > > >
> > > > Argonne National Laboratory
> > > > Lemont, IL 60439, USA
> > > >
> > > > jdoerfert at anl.gov
> > > > _______________________________________________
> > > > LLVM Developers mailing list
> > > > llvm-dev at lists.llvm.org
> > > > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> > > >
> >
> > --
> >
> > Johannes Doerfert
> > Researcher
> >
> > Argonne National Laboratory
> > Lemont, IL 60439, USA
> >
> > jdoerfert at anl.gov
>
>
>
> --
>
> Johannes Doerfert
> Researcher
>
> Argonne National Laboratory
> Lemont, IL 60439, USA
>
> jdoerfert at anl.gov
More information about the llvm-dev
mailing list