[llvm-dev] [RFC] High-Level Code-Review Documentation Update
Hubert Tong via llvm-dev
llvm-dev at lists.llvm.org
Mon Dec 2 08:52:33 PST 2019
On Thu, Nov 14, 2019 at 10:46 PM Finkel, Hal J. via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> 3. All comments by reviewers should be addressed by the patch author.
> It is generally expected that suggested changes will be incorporated
> into the next revision of the patch unless the author and/or other
> reviewers can articulate a good reason to do otherwise (and then the
> reviewers must agree).
I disagree on the high bar here. The author should acknowledge the
comments; however, addressing all of the comments in one shot has similar
problems as having commits that are too large (diffs between revisions
become more difficult to review). This also leads to significant timing
issues, where the comments made overnight in some time zone are addressed
by the author locally, but someone added comments in the afternoon the next
day before the author has a chance to post the new revision.
> If you suggest changes in a code review, but
> don't wish the suggestion to be interpreted this strongly, please state
> so explicitly.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev