[llvm-dev] RFC Enable -Wimplicit-fallthrough for clang as well as GCC

[Reid Kleckner via llvm-dev]

I split all the possible behavior changes out of the big cleanup patch, and
committed the cleanup as r345882.

I enabled the warning in r345887, and I'll see if it sticks.

Thanks for the reviews!

On Thu, Nov 1, 2018 at 10:25 AM Reid Kleckner <rnk at google.com> wrote:

> Great! Thanks everyone for the input, I'm going to start splitting up the
> patch. I'll send out the non-mechanical parts separately.
>
> On Wed, Oct 31, 2018 at 10:03 PM Chris Lattner <sabre at nondot.org> wrote:
>
>> On Oct 31, 2018, at 2:24 PM, Reid Kleckner <rnk at google.com> wrote:
>>
>> Alex Kornienko proposed enabling this warning back in 2012 here:
>> http://lists.llvm.org/pipermail/llvm-dev/2012-July/051386.html
>>
>> At the time, Chris Lattner said he didn't feel it was worth annotating
>> all of LLVM and Clang with a new macro to enable this warning.
>>
>>
>> FWIW, I formally withdraw my objection, go for it! :-)
>>
>> -Chris
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20181101/365ca316/attachment.html>