[llvm-dev] [SROA][DebugInfo][GSoC] Testing SROA on amalgamated sqlite source

[Adrian Prantl via llvm-dev]

> On May 31, 2018, at 5:11 AM, Anast Gramm <anastasis.gramm2 at gmail.com> wrote:
> 
>> That is good to hear / expected, since we went though great lengths to ensure that SROA preserves variable debug info. 
>> 
>> Have you looked at the location-less phi instructions?
>> Does empty mean line 0 or do you mean they have no debug location whatsoever?
> 
> Most of them have line 0, only 12 are locationless.
> 
>> Are they empty for good reasons or does it look more like an oversight in the implementation?
> 
> How can I approach this? My guess is that all these phi's are with line 0 because they are made
> of stores and allocas that aren't actual code, and are instead generated by clang. Like here
> https://reviews.llvm.org/D47097 at test1

My guess is that the ones with line 0 are intentional and deliberately set the location to line 0 because someone already put thought into this, and the ones without location are more likely to be bugs. Since there are only 12 you can probably just look at them individually and determine where they are generated and then we can decide whether the code is behaving correctly or not.

-- adrian