[llvm-dev] CodeView layering

[Zachary Turner via llvm-dev]

Yes, some of the headers and stuff that are just raw structure definitions
and enums could probably be sunk into BinaryFormat..

How'd you find this?  Curious why it hasn't been breaking in modules builds
for a long time.

On Wed, Mar 21, 2018 at 11:31 AM David Blaikie <dblaikie at gmail.com> wrote:

> I'm looking at fixing some layering violations in LLVM & came across a few
> in the CodeView handling, specifically:
>
> lib/MC/MCCodeView includes several llvm/DebugInfo/CodeView headers
>   I guess MC could be made dependent on DebugInfoCodeView? But probably
> these things should be sunk into BinaryFormat as is the case for DWARF
> features used by MC?
>
> include/llvm/Object/COFF.h includes
> include/llvm/DebugInfo/CodeView/CVDebugRecord.h
>   Also seems like this could/should/needs to be sunk into BinaryFormat?
>
> I'm open to ideas & happy to do the work, or help in any way that might be
> useful.
>
> Thanks,
> - Dave
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180321/781d8d44/attachment.html>