[llvm-dev] RFC: XRay FDR/Profiling Mode Moving to Post-Commit Review

Eric Christopher via llvm-dev llvm-dev at lists.llvm.org
Tue Jul 17 14:07:32 PDT 2018


As long as your changes are under
https://llvm.org/docs/DeveloperPolicy.html#code-reviews I don't see any
problems. Incrementally adding your work and having it done in post
shouldn't be a problem. If there's some large or major change then it's
probably good to send it out for others to look at - no different than any
other part of llvm.

-eric

On Mon, Jul 16, 2018 at 10:00 PM Dean Michael Berris <dean.berris at gmail.com>
wrote:

> On Tue, Jul 17, 2018 at 2:47 PM Dean Michael Berris
> <dean.berris at gmail.com> wrote:
> >
> > Hi llvm-dev,
> >
> ...
> >
> > My intent is to land these in the next few hours and iterate on
> > post-commit review comments.
> >
>
> I sent this message in haste, this should instead say:
>
> If it's alright with the community, I would like to land these in the
> next few days and iterate on post-commit review.
>
> Feedback would be most appreciated.
>
> Cheers
>
> --
> Dean
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180717/419ab6b7/attachment.html>


More information about the llvm-dev mailing list