[llvm-dev] [Openmp-dev] [cfe-dev] [Release-testers] [6.0.0 Release] Release Candidate 2 tagged

[Hans Wennborg via llvm-dev]

On Sun, Feb 11, 2018 at 3:31 PM, Dimitry Andric <dimitry at andric.com> wrote:
> On 9 Feb 2018, at 22:30, Dimitry Andric <dimitry at andric.com> wrote:
>>
>> On 9 Feb 2018, at 22:11, Dimitry Andric via Openmp-dev <openmp-dev at lists.llvm.org> wrote:
>>>
>>> On 9 Feb 2018, at 20:40, Dimitry Andric via cfe-dev <cfe-dev at lists.llvm.org> wrote:
>>>>
>>>>> On 9 Feb 2018, at 10:20, Hans Wennborg <hans at chromium.org> wrote:
>>> ...
>>>>> What are all these test failures? Does it seems like they have a
>>>>> common root cause and do we have a bug for it?
>>> ...
>>>> The Clang Tools and Extra Tools Unit tests all appear to crash with:
>>>>
>>>>  exception_ptr not yet implemented
>>>
>>> This turns out to be caused by libc++ being compiled without -DLIBCXXRT.  (In the FreeBSD base system build, we always add this option, so libc++ knows how to handle exceptions.)
>>>
>>> In the libc++ CMakeFiles, it appears to be governed by LIBCXX_CXX_ABI_LIBNAME, but it isn't being set to the correct value of "cxxrt" on FreeBSD.  I am going to try the following diff:
>>>
>>> --- llvm.src/projects/libcxx/CMakeLists.txt
>>> +++ llvm.src/projects/libcxx/CMakeLists.txt
>>> @@ -135,6 +135,8 @@
>>>  elseif (APPLE)
>>>    set(LIBCXX_CXX_ABI_LIBNAME "libcxxabi")
>>>    set(LIBCXX_CXX_ABI_SYSTEM 1)
>>> +  elseif (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
>>> +    set(LIBCXX_CXX_ABI_LIBNAME "libcxxrt")
>>>  else()
>>>    set(LIBCXX_CXX_ABI_LIBNAME "default")
>>>  endif()
>>
>> ... and unfortunately that didn't work, since the CMakeFiles are unable to find the libcxxrt headers:
>>
>> CMake Warning at projects/libcxx/cmake/Modules/HandleLibCXXABI.cmake:67 (message):
>>  Failed to find cxxabi.h
>> Call Stack (most recent call first):
>>  projects/libcxx/cmake/Modules/HandleLibCXXABI.cmake:112 (setup_abi_lib)
>>  projects/libcxx/CMakeLists.txt:428 (include)
>
> Ok, this turned out to be easier than I thought.  After applying https://reviews.llvm.org/D43166, the number of failed tests drops roughly by half (from 896 to 512):
>
>   Expected Passes    : 45381
>   Expected Failures  : 185
>   Unsupported Tests  : 2937
>   Unexpected Passes  : 1
>   Unexpected Failures: 521
>
> I am going to have a look at some other low hanging fruit, and I have also created a few PRs to merge test changes into 6.0.

Nice!

It sounds like most of this is stuff that's always been failing, so
I'm not going to worry too much, but it's very nice to see the error
numbers go down.

Thanks,
Hans