[llvm-dev] Reviewers for minor fix needed - D43146

John Paul Adrian Glaubitz via llvm-dev llvm-dev at lists.llvm.org
Mon Aug 27 04:04:54 PDT 2018


Hi!

in rL324593 [1], a workaround was implemented to fix an infinite
recursion with the c?zdi2 builtins. Unfortunately, the change in
[1] is not 100% correct as - for example - assumes that a 64-Bit
SPARC environment always defines the macro "__sparc64__" which is
not correct for Linux but for BSD (and Solaris?) systems only.

The more portable approach is to check for __sparc__ and __arch64__
(not to be confused with __aarch64__). The change to fix this can
be found in [2].

Could someone review and merge it so the workaround doesn't have to
be patched locally anymore to workaround the problem on Linux/sparc64?

Thanks,
Adrian

> [1] https://reviews.llvm.org/rL324593
> [2] https://reviews.llvm.org/D43146

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


More information about the llvm-dev mailing list