[llvm-dev] [lld] - LLD (ELF) code covered by test cases.

[Peter Smith via llvm-dev]

Thanks very much for running the experiment, that is useful information.

On 26 April 2018 at 14:11, George Rimar via llvm-dev
<llvm-dev at lists.llvm.org> wrote:

>
> 2) In Relocations.cpp, all code inside `if`:
> https://github.com/llvm-mirror/lld/blob/master/ELF/Relocations.cpp#L1177
> Is not covered by tests.
>

I'll volunteer to add a test case for that one. Will hopefully have
something at least by early next week.

> Now we probably can think about what we can do with that?
> * Ideal scenario I can imagine is that we could fix all the places and, for
> example, setup the watching bot
> looking for LLD code coverage for each commit.
> * Minimal scenario I see is to fix the major known places mentioned at
> least.
>

> What do you think guys?

I agree that we should fix the areas that are missing in the report. I
think it would be a great just to have the coverage information
available to look at as it would be useful to add extra tests for
areas that we'd missed. Whether such a bot should be silent, warn or
error based on some heuristic is a trickier question.

Peter

>
>
> Best regards,
> George | Developer | Access Softek, Inc
>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>