[llvm-dev] PSA: Potential lit workflow change

[Zachary Turner via llvm-dev]

Actually I'm wrong.  llvm-lit is automatically put into the bin directory
by CMake itself.  You don't have to run ninja at all.

On Wed, Sep 13, 2017 at 11:44 AM Vedant Kumar <vsk at apple.com> wrote:

> On Sep 13, 2017, at 11:43 AM, Zachary Turner <zturner at google.com> wrote:
>
> s/run this lit target manually/run this CMake target manually (e.g. `ninja
> llvm-lit`)/
>
>
> Great, thanks!
>
> vedant
>
>
> On Wed, Sep 13, 2017 at 11:42 AM Zachary Turner <zturner at google.com>
> wrote:
>
>> llvm-lit is already put into <output-tree>/bin by CMake.
>>
>> There is a CMake target called `llvm-lit` that will generate the
>> <output-dir>/bin/llvm-lit script.  If you built only a few specific llvm
>> targets such as FileCheck, etc then you may need to run this lit target
>> manually.  If you just run "ninja" for example, or "ninja check-llvm", it's
>> automatically generated.
>>
>> On Wed, Sep 13, 2017 at 11:39 AM Vedant Kumar <vsk at apple.com> wrote:
>>
>>> Thanks for working on this.
>>>
>>> One question: do you know what's the fastest way to create a working
>>> <output-tree>/bin/llvm-lit program? By 'working', I mean: assuming I've
>>> already built llvm-config and the relevant test dependencies (FileCheck,
>>> opt, etc), I can run llvm-lit on a single test.
>>>
>>>
>>> On Sep 13, 2017, at 9:19 AM, Zachary Turner via llvm-dev <
>>> llvm-dev at lists.llvm.org> wrote:
>>>
>>> Hi all, I've got https://reviews.llvm.org/D37756 up for review
>>> currently which simplifies a lot of the logic in our lit config files.
>>>
>>> For most people, this will be completely transparent and "just work",
>>> but it breaks one workflow that people should be aware of.
>>>
>>> Problem: If you run lit by putting llvm-config in your path and then
>>> running <source-root>/utils/lit/lit.py <source-root>/<path-to-test-file>
>>> then this is not going to work anymore.
>>>
>>> Luckily, there's an easy fix:
>>>
>>> Solution: Run <output-tree>/bin/llvm-lit.py
>>> <source-root>/<path-to-test-file>
>>>
>>>
>>> Will llvm-lit.py be added to <output-tree>/bin, or is this supposed to
>>> be <output-tree>/bin/llvm-lit?
>>>
>>> vedant
>>>
>>>
>>> Happy to answer any questions here or on the code review.
>>>
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>
>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170913/217d275b/attachment.html>