[llvm-dev] ThinLTO with Linux+ELF+Gold -- incorrectly dropping weak definitions.

[Teresa Johnson via llvm-dev]

+pcc who may have some thoughts

But yes, it is legal to mix -flto and -flto=thin - at link time we'll do
regularLTO across all the -flto objects and thinLTO on the -flto=thin
objects, and the resulting native objects all get linked in the end.

But if you do -flto=thin we should get a summary block (it will be empty if
there are no global values, but we should still do ThinLTO compilation on
it). There was a time in the past when we would not generate a summary
block when we had inline assembly, as a workaround for some other issues,
but that has been fixed. If you are seeing no summary block generated with
-flto=thin, can you send me a reproducer? Especially if it reproduces at
head.

Are the issues reported in the bug related to objects that are being
handled by regularLTO?

Teresa


On Wed, May 17, 2017 at 10:42 AM, David Callahan <dcallahan at fb.com> wrote:

> I have now observed that some of the object files, while compiled
> -flto=thin and determined to be missing the ThinLTOSummary and are being
> lumped into the "regularLTO" pass. This might explain some of my problem.
> Under what conditions would this summary be missing? Is it ever legal to
> mix -flto and -flto=thin object files?
> ------------------------------
> *From:* Teresa Johnson <tejohnson at google.com>
> *Sent:* Tuesday, May 16, 2017 9:52:47 AM
> *To:* David Blaikie
> *Cc:* David Callahan; LLVM Dev Mailing list
> *Subject:* Re: [llvm-dev] ThinLTO with Linux+ELF+Gold -- incorrectly
> dropping weak definitions.
>
> This looks similar to the problem I fixed awhile back in r292408. I'll
> take a look (probably tomorrow since I am taking some vacation today).
> Teresa
>
> On Tue, May 16, 2017 at 9:43 AM, David Blaikie <dblaikie at gmail.com> wrote:
>
>> +Teresa
>>
>> On Mon, May 15, 2017 at 9:20 AM David Callahan via llvm-dev <
>> llvm-dev at lists.llvm.org> wrote:
>>
>>> I am tracking a problem with ThinLTO on Linux using gold and elf files
>>> where there is a disconnect between gold’s treatment of comdat groups and
>>> ThinLTO’s decisions about which weak references to convert to available
>>> externally.  The net result is a definition is lost and a relocation entry
>>> is not handled.
>>>
>>>
>>>
>>> My status is summarized: https://bugs.llvm.org/show_bug.cgi?id=32980
>>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.llvm.org_show-5Fbug.cgi-3Fid-3D32980&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=lFyiPUrFdOHdaobP7i4hoA&m=DPiCkl9b6jP9-AMbNn0dugb9gFBlyNOKzRq3medq--c&s=DrEkmqUOt4bTaMEhOHPJpR7t5uuU7ux0362_rqDXoT4&e=>
>>>
>>>
>>>
>>> Anyone familiar with this space and have guidance? Either on how to
>>> avoid the problem, or a patch to correct it?
>>>
>>>
>>>
>>> Thanks
>>>
>>> --david
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=lFyiPUrFdOHdaobP7i4hoA&m=DPiCkl9b6jP9-AMbNn0dugb9gFBlyNOKzRq3medq--c&s=jrvmGThXXfA5_gGaW24C9hKIgZx6bOjrBEVc_LHKMZQ&e=>
>>>
>>
>
>
> --
> Teresa Johnson |  Software Engineer |  tejohnson at google.com |
> 408-460-2413 <(408)%20460-2413>
>



-- 
Teresa Johnson |  Software Engineer |  tejohnson at google.com |  408-460-2413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170517/ab38f5a0/attachment-0001.html>