[llvm-dev] [cfe-dev] Modernizing LLVM Coding Style Guide and enforcing Clang-tidy

[Piotr Padlewski via llvm-dev]

2017-01-09 19:29 GMT+01:00 Renato Golin <renato.golin at linaro.org>:

> On 9 January 2017 at 18:20, Reid Kleckner <rnk at google.com> wrote:
> > I object to the first. If you need a new type name, use a typedef. It's
> time
> > honored and everyone, including C programmers, will know what you're
> doing.
> > I don't understand why people push the new thing just for the sake of
> > new-ness.
>
> The text read "prefer", which I think it's fair. I'm opposed to any
> hard rule for the sake of new-ness, consistency, or personal
> preference.
>
> If we encode all nit-rules as "prefer", then it should be more like a
> guideline than a rule book, which has been our motto for everything
> else.
>
> cheers,
> --renato
>

That's right, everyone has some preferences, but as long as most (over 75%)
of the community prefer one thing over another then I guess it would make
sense to convice the rest and make it official by writing it down. Then we
won't have to spend time dicussing the same things over and over on
different reviews. It is just much simpler to point new (or not)
contributor to a rule in style guide.

Piotr
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20170109/399264f8/attachment.html>