[llvm-dev] RFC: Reconsidering adding gmock to LLVM's unittest utilities

Renato Golin via llvm-dev llvm-dev at lists.llvm.org
Fri Jan 6 02:24:23 PST 2017

On 6 January 2017 at 00:01, Chandler Carruth via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> 1) add the utility code
> 2) use it in the *clear* places where it makes a substantial improvement,
> both matchers and mocks

Sounds like a plan.

> I'd really like to hear if there are serious concerns here, but so far this
> looks like pretty strong consensus. If possible I'd like to make progress on
> landing the actual code Friday, so if you haven't given a shout yet, please
> do. Of course, if new concerns come up, we can always revisit this. It's
> just internal testing utilities, so it seems especially low-risk.

This is in line with existing infrastructure in the unit-tests,
test-suite and libc++ benchmarking, so I don't think there should be
any contentious issues.

Maintenance would be a problem whether we use a third-party suite or
develop our own (more likely higher in the latter case).

> b) We will definitely want some guidelines around *how* and *when* to use
> this stuff.

YES! We didn't even know libc++ had a benchmark utility at the libc++ BoF.

Just a mention on how to add tests would be a long way towards more
tests. Pointing to existing docs would be more than ok.

We can start slow in that front, too, but it would be great if we
could get some traction there in the long run.


More information about the llvm-dev mailing list