[llvm-dev] RFC/bikeshedding: Separation of instruction and pattern definitions in LLVM backends

Alex Bradbury via llvm-dev llvm-dev at lists.llvm.org
Fri Aug 18 06:10:59 PDT 2017


On 18 August 2017 at 13:02, John Leidel <john.leidel at gmail.com> wrote:
> I agree with David's sentiment.  The second method appears to be easier to
> follow.  IMHO, this would be easier for external users that desire to modify
> the backend for their own custom extensions/instructions.

Hi David and John, thanks for the feedback. I realise I didn't express
my view in the original email - I also feel that the second approach
works out as cleaner. As you say, it seems plausible that the
separation will make it easier to add new custom
extensions/instructions and we expect that to be a common activity.
The main reason I'm sharing for wider feedback is to ensure there
aren't further options that haven't been considered, as it's not going
to be painful to introduce such refactorings further down the line.

Best,

Alex


More information about the llvm-dev mailing list