[llvm-dev] Benchmarks for LLVM-generated Binaries

Dean Michael Berris via llvm-dev llvm-dev at lists.llvm.org
Wed Sep 14 00:50:05 PDT 2016


I'm working on this now, and I had a few more questions below for Renato and the list in general. Please see inline below.

> On 2 Sep 2016, at 11:27, Dean Michael Berris <dean.berris at gmail.com> wrote:
> 
>> On 2 Sep 2016, at 11:19, Renato Golin <renato.golin at linaro.org> wrote:
>> 
>> On 2 September 2016 at 02:13, Dean Michael Berris <dean.berris at gmail.com> wrote:
>>> I think it should be possible to have a snapshot of it included. I don't know what the licensing implications are (I'm not a lawyer, but I know someone who is -- paging Danny Berlin).
>> 
>> The test-suite has a very large number of licenses (compared to LLVM),
>> so licensing should be less of a problem there. Though Dan can help
>> more than I can. :)
>> 
> 
> Cool, let's wait for what Danny thinks on the patch I'll be preparing. :)
> 
>> 
>>> I'm not as concerned about falling behind on versions there though mostly because it should be trivial to update it if we need it. Though like you, I agree this isn't the best way of doing it. :)
>> 
>> If we start using it more (maybe we should, at least for the
>> benchmarks, I've been long wanting to do something decent there), then
>> we'd need to add a proper update procedure.
>> 
>> I'm fine with some checkout if it's a stable release, not trunk, as it
>> would make things a lot easier to update later (patch releases, new
>> releases, etc).
>> 
> 
> SGTM.
> 

Is there a preference on where to place the library? I had a look at {SingleSource/MultiSource}/Benchmarks/ and I didn't find a common location for libraries used. I'm tempted to create a top-level "libs" directory that will host common libraries but I'm also fine with just having the benchmark library living alongside the XRay benchmarks.

So two options here:

1) libs/googlebenchmark/
2) MultiSource/Benchmarks/XRay/googlebench/

Thoughts?

Cheers

-- Dean



More information about the llvm-dev mailing list