[llvm-dev] Adding asan poison to Recycler and ArrayRecycler

[Nicolai Hähnle via llvm-dev]

Hi all,

I intend to add address sanitizer (un)poison calls to Recycler and 
ArrayRecycler since I spent a few hours tracking down a bug in the 
AMDGPU backend that turned out to be a use-after-free that would have 
been detected by asan if it weren't for the Recycler. See 
https://reviews.llvm.org/D25313.

Naturally, such a change exposes a bunch of bugs or things that are 
dodgy and happen not to be problematic today, but might easily break in 
the future, across all backends. I have prepared patches to fix all the 
issues in the CodeGen/AMDGPU lit tests; all the non-AMDGPU fixes are 
rolled into the patch above (although it probably makes sense to commit 
them first as a separate change before switching asan on). But it's 
clearly not my job to fix the inevitable build bot regressions in other 
backends.

How do you want to handle this?

Cheers,
Nicolai