[llvm-dev] leaks in lld on the bot

[Rafael Avila de Espindola via llvm-dev]

I don't think unique _ptr (at least with the default deleter) is desirable as we do benefit from pool allocation.

Cheers,
Rafael

On November 7, 2016 9:21:15 PM EST, Davide Italiano via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>On Mon, Nov 7, 2016 at 6:19 PM, Davide Italiano <davide at freebsd.org>
>wrote:
>> On Mon, Nov 7, 2016 at 5:53 PM, Davide Italiano <davide at freebsd.org>
>wrote:
>>> On Mon, Nov 7, 2016 at 4:43 PM, Kostya Serebryany via llvm-dev
>>> <llvm-dev at lists.llvm.org> wrote:
>>>> The asan bootstrap bot is unhappy with lld.
>>>> Rui, os someone, please take a look.
>>>>
>>>>
>http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/138/steps/check-lld%20asan/logs/stdio
>>>>
>>>> ==26011==ERROR: LeakSanitizer: detected memory leaks
>>>>
>>>> Direct leak of 184 byte(s) in 1 object(s) allocated from:
>>>>     #0 0x72fab0 in operator new(unsigned long)
>>>>
>/mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:82
>>>>     #1 0x8c8610 in void
>>>>
>lld::elf::BinaryFile::parse<llvm::object::ELFType<(llvm::support::endianness)1,
>>>> true> >()
>>>>
>/mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/lld/ELF/InputFiles.cpp:823:7
>>>>     #2 0xb9de74 in
>>>>
>lld::elf::SymbolTable<llvm::object::ELFType<(llvm::support::endianness)1,
>>>> true> >::addFile(lld::elf::InputFile*)
>>>>
>/mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/lld/ELF/SymbolTable.cpp:61:8
>>>>     #3 0x82c46f in void
>>>>
>lld::elf::LinkerDriver::link<llvm::object::ELFType<(llvm::support::endianness)1,
>>>> true> >(llvm::opt::InputArgList&)
>>>>
>/mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/lld/ELF/Driver.cpp:723:12
>>>>     #4 0x819578 in lld::elf::LinkerDriver::main(llvm::ArrayRef<char
>const*>,
>>>> bool)
>>>>
>/mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/lld/ELF/Driver.cpp:333:5
>>>>     #5 0x8174b8 in lld::elf::link(llvm::ArrayRef<char const*>,
>bool,
>>>> llvm::raw_ostream&)
>>>>
>/mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/lld/ELF/Driver.cpp:56:11
>>>>     #6 0x73432f in main
>>>>
>/mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm/tools/lld/tools/lld/lld.cpp:104:13
>>>>     #7 0x7fc345503f44 in __libc_start_main
>>>> (/lib/x86_64-linux-gnu/libc.so.6+0x21f44)
>>>>
>>>> SUMMARY: AddressSanitizer: 184 byte(s) leaked in 1 allocation(s).
>>>>
>>>> --kcc
>>>>
>>>
>>> r286193 fixes the inlined failure. There are other 130 outstanding
>>> failures, I'm taking a look at them now.
>>>
>>
>> There are no more tests failing in ELF/. All the remaining failures
>> are in COFF, I'm not super-familiar with the code so I'll let someone
>> else fixing them.
>>
>
>Oh I want to point out that maybe these bugs open a case for switching
>back to the old resource lifetime management (using unique_ptr<>)
>instead of naked `new`. CC:ing dblaikie as he pointed out similar
>issues in the post-commit review that did the switch. Rui, what do you
>think?
>
>-- 
>Davide
>
>"There are no solved problems; there are only problems that are more
>or less solved" -- Henri Poincare
>_______________________________________________
>LLVM Developers mailing list
>llvm-dev at lists.llvm.org
>http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161108/57ad9fcc/attachment.html>