[llvm-dev] Phabricator not getting all comments sent by email?

[Chandler Carruth via llvm-dev]

On Thu, May 19, 2016 at 1:11 PM Justin Bogner via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> James Y Knight via llvm-dev <llvm-dev at lists.llvm.org> writes:
> > GAH! Sigh.... :(
> >
> > That is indeed what it does. See stripQuotedText
> > in src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php
> if
> > anyone's interested in hacking on php code, it looks like it might be
> > fairly straightforward to have it strip only the lines starting with ">"
> > after the "On ... wrote:" line.
>
> Wouldn't that be confusing? Such comments tend to refer to the quoted
> text just before the comment. We'd probably want to keep some arbitrary
> number of the quoted lines before each comment or something.
>
> Note also that if we fix that we should probably also teach phab not to
> re-send comments to the list when the list and phab were both on cc.
> AFAICT any top posted comments on phab reviews show up on the list twice
> currently, once from the author and once from phab.
>

Maybe file both of these in the Phab bug component?


>
>
> > On Thu, May 19, 2016 at 3:21 PM, Tim Northover <t.p.northover at gmail.com>
> > wrote:
> >
> >> On 19 May 2016 at 11:59, James Y Knight via llvm-dev
> >> <llvm-dev at lists.llvm.org> wrote:
> >> > Does anyone know why phab sometimes misses replies sent by email?
> Usually
> >> > they make it through, but sometimes not.
> >>
> >> I think I've noticed it dropping e-mails that start with quotes
> >> before, and certainly ignoring everything below the first quote line.
> >> It seems to assume everyone will be top-posting.
> >>
> >> Tim.
> >>
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160520/1eb0c088/attachment.html>