[llvm-dev] [RFC] Helping release management
Mehdi Amini via llvm-dev
llvm-dev at lists.llvm.org
Tue May 17 12:44:45 PDT 2016
> On May 17, 2016, at 12:43 PM, Renato Golin <renato.golin at linaro.org> wrote:
>
> On 17 May 2016 at 20:40, Mehdi Amini <mehdi.amini at apple.com> wrote:
>> I don't see why?
>> The notion of title is already just a convention, any tool that look at the title has to filter it out of the full commit message in the first place AFAIK.
>> So I don't see any obstacle to have a regex that would match any part of the commit message.
>
> So, when I revert patches (using the git-svn script), it sets the
> title to: "Revert: <old title>" then writes on the body *only* "This
> reverts commit rNNNNN.".
>
> Unless the git-hook has a way look into rNNNN's commit message, or the
> PR is on the title, I don't know how it would match it...
Updating the git-svn tool to find the PR in the original commit and adding the information in the revert seems appropriate to me here.
--
Mehdi
More information about the llvm-dev
mailing list